Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All integrations tests should run in openstack #413

Merged
merged 21 commits into from
Dec 18, 2024

Conversation

javierdelapuente
Copy link
Collaborator

@javierdelapuente javierdelapuente commented Dec 3, 2024

Applicable spec:

Overview

We want all generic integration tests to run in openstack, as local lxd will be used in another track (not the latest one).

This PR uses openstack for the three integration tests that were using lxd, that is:

  • test_charm_scheduled_events
  • test_debug_ssh
  • test_charm_upgrade

More cleaning will be done in subsequent PRs.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation is generated using src-docs.
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The changes do not introduce any regression in code or tests related to LXD runner mode.

@javierdelapuente javierdelapuente changed the title increate image builder revision All integrations tests should run in openstack Dec 3, 2024
@canonical canonical deleted a comment from github-actions bot Dec 3, 2024
Copy link
Collaborator

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good! Have only nitpicks.

.github/workflows/integration_test.yaml Show resolved Hide resolved
tests/integration/conftest.py Outdated Show resolved Hide resolved
tests/integration/test_debug_ssh.py Outdated Show resolved Hide resolved
@cbartz cbartz requested a review from yhaliaw December 17, 2024 07:14
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
.github/workflows/integration_test.yaml Show resolved Hide resolved
tests/integration/conftest.py Show resolved Hide resolved
tests/integration/helpers/lxd.py Outdated Show resolved Hide resolved
Copy link
Contributor

Test coverage for 9a1d25e

Name                         Stmts   Miss Branch BrPart  Cover   Missing
------------------------------------------------------------------------
src/charm.py                   655    150    140     27    74%   254-256, 322-341, 359-361, 362->366, 392-396, 470-472, 481, 488-490, 511-516, 533-538, 559, 571-577, 592-593, 612-613, 622, 627, 657-658, 660->669, 664->669, 674-681, 715, 719-724, 776, 788->791, 814-826, 830-831, 864-865, 877-894, 918-920, 939-949, 1029-1030, 1032-1033, 1035-1036, 1115->1117, 1182-1183, 1221-1223, 1231-1239, 1315-1348, 1362-1367, 1382-1425, 1433-1434, 1456
src/charm_state.py             450     17     82      3    95%   274-286, 505-509, 631-632, 687-688, 1123->1126, 1130-1131, 1178
src/errors.py                   25      0      0      0   100%
src/event_timer.py              52      6      0      0    88%   105-106, 143-144, 160-161
src/firewall.py                 51     18     10      0    67%   42-43, 66-69, 111-185
src/github_client.py            23      2      4      0    93%   71-72
src/logrotate.py                43      0      2      0   100%
src/lxd_type.py                 35      0      0      0   100%
src/runner_manager_type.py      39      0      0      0   100%
src/runner_type.py              38      0      0      0   100%
src/shared_fs.py                98     17     10      1    83%   60-61, 132-133, 162-163, 171-172, 178-179, 210, 213-214, 226-227, 270-271
src/utilities.py                32      4      6      2    79%   66-69, 111
------------------------------------------------------------------------
TOTAL                         1541    214    254     33    84%

Static code analysis report

Run started:2024-12-17 13:16:17.579604

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5084
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 6

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@javierdelapuente javierdelapuente merged commit 3dba162 into main Dec 18, 2024
53 checks passed
@javierdelapuente javierdelapuente deleted the integration-tests-lxd-to-openstack branch December 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants