Remove dqlite-next build configuration #704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 85.74% 85.66% -0.09%
==========================================
Files 197 197
Lines 29040 29034 -6
Branches 4084 4065 -19
==========================================
- Hits 24901 24872 -29
+ Misses 3915 3873 -42
- Partials 224 289 +65 ☔ View full report in Codecov by Sentry. |
letFunny
approved these changes
Sep 17, 2024
src/raft/uv_encoding.c
Outdated
| res += 8; /* Local data length, applies to all entries */ | ||
| #endif | ||
| } | ||
| (void)with_local_data; |
There was a problem hiding this comment.
Can you add a TODO or something in each of these methods saying that this argument is not used and should be removed, same with the local data struct declaration.
There was a problem hiding this comment.
I am okay removing them later, but we need to keep track of it.
There was a problem hiding this comment.
Yep, good catch.
There was a problem hiding this comment.
I went ahead and removed the remaining traces of the local_data work.
Signed-off-by: Cole Miller <cole.miller@canonical.com>
I've preserved is_local since it's still potentially useful. Signed-off-by: Cole Miller <cole.miller@canonical.com>
cole-miller
force-pushed
the
remove-dqlite-next-gate
branch
from
680cf42
to
474ed25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cole Miller cole.miller@canonical.com