Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build when liblz4 is missing and test it #693

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

cole-miller
Copy link
Contributor

@cole-miller cole-miller commented Aug 30, 2024

The build was broken when --enable-build-raft was passed and liblz4 was missing due to a logic error in configure.ac. Fix this and test this particular build configuration in CI.

I only noticed this because we don't install liblz4-dev for the PPA builds and it's preventing setting --enable-build-raft there (canonical/dqlite-ppa#7).

Signed-off-by: Cole Miller <cole.miller@canonical.com>
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (27eeeaf) to head (1dc45ba).
Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   77.97%   77.88%   -0.10%     
==========================================
  Files         197      197              
  Lines       28066    28007      -59     
  Branches     5544     5538       -6     
==========================================
- Hits        21885    21812      -73     
- Misses       4329     4349      +20     
+ Partials     1852     1846       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cole-miller cole-miller marked this pull request as ready for review August 30, 2024 00:46
@cole-miller cole-miller merged commit 12bfbd2 into canonical:master Sep 2, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant