Support QUERY and QUERY_SQL that modify the database #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-miller
force-pushed
the
modifying-query
branch
from
80f731c
to
a51dc5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 58.73% 58.85% +0.12%
==========================================
Files 33 33
Lines 5869 5916 +47
Branches 1762 1778 +16
==========================================
+ Hits 3447 3482 +35
Misses 1358 1358
- Partials 1064 1076 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Cole Miller <cole.miller@canonical.com>
cole-miller
force-pushed
the
modifying-query
branch
from
a51dc5e
to
d564cfd
Compare
|
Rebased and ready for review. |
MathieuBordere
approved these changes
Feb 22, 2023
|
|
||
| is_readonly = (bool)sqlite3_stmt_readonly(stmt->stmt); | ||
| if (is_readonly) { | ||
| rv = leader__barrier(g->leader, &g->barrier, query_barrier_cb); |
There was a problem hiding this comment.
Don't let it stop you (it's there in original code), but where do we send a failure response if this call or leader__exec in the other branch fails?
There was a problem hiding this comment.
We end up returning nonzero from handle_query, which turns into a nonzero return from gateway__handle, which is handled here:
Lines 156 to 159 in 690818b
So we don't send a failure response and just close the connection instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471. This is based on #476, I'll rebase onto master once that merges.
As suggested by @freeekanayaka, we don't support modifying statements that also return rows (for now). Modifying statements submitted with QUERY or QUERY_SQL go through exactly the same codepath as if submitted with EXEC or EXEC_SQL, respectively, except that we send an empty ROWS response instead of a RESULT response.
Signed-off-by: Cole Miller cole.miller@canonical.com