Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds NFS CSI plugin integration test #11

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

claudiubelu
Copy link
Contributor

The Helm chart is for deploying the NFS CSI plugin, but it requires the CSI components as well.

@claudiubelu claudiubelu requested a review from a team as a code owner August 5, 2024 08:06
@claudiubelu claudiubelu marked this pull request as draft August 6, 2024 06:03
@claudiubelu claudiubelu force-pushed the adds-integration-test-nfs branch from f050a7d to d6248e1 Compare August 6, 2024 06:47
@claudiubelu claudiubelu force-pushed the adds-integration-test-nfs branch from d6248e1 to ef90c2b Compare August 15, 2024 18:58
@claudiubelu claudiubelu marked this pull request as ready for review August 16, 2024 06:17
bschimke95
bschimke95 previously approved these changes Aug 20, 2024
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 dismissed their stale review August 20, 2024 08:12

Actually, it looks like the liveness probe test fails. Please have a look

@bschimke95
Copy link
Collaborator

I guess this needs to be rebased to the latest fix, right?

The Helm chart is for deploying the NFS CSI plugin, but it
requires the CSI components as well.

The test will also check the Pod probes to make sure that the service is
up, without waiting for Kubernetes to do the check.

The test will also spawn a NFS server, and create an NGINX Pod requiring
a NFS volume.
@claudiubelu claudiubelu force-pushed the adds-integration-test-nfs branch from ef90c2b to ee0ffc3 Compare August 22, 2024 07:31
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 7f3a894 into canonical:main Aug 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants