Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mknod intercepts now configurable from LXDProvider #717

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feat: mknod intercepts now configurable from LXDProvider #717

merged 4 commits into from
Jan 16, 2025
+24 −3

Conversation

mattculler
Copy link
Contributor

@mattculler mattculler commented Jan 15, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Allow craft-application's ProviderService to dis/allow intercepting mknod calls in LXD.

canonical/craft-application#607

@mattculler mattculler linked an issue Jan 15, 2025 that may be closed by this pull request
Don't set security.syscalls.intercept.mknod=true for LXD provider #191
Closed
@mattculler mattculler mentioned this pull request Jan 15, 2025
Open
3 tasks
@mattculler mattculler marked this pull request as ready for review January 16, 2025 15:44
@mattculler mattculler self-assigned this Jan 16, 2025
@upils upils requested review from upils and mr-cal January 16, 2025 16:11
@mattculler mattculler requested a review from a team January 16, 2025 20:00
lengau
lengau approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog item :-)

@mattculler mattculler force-pushed the work/CRAFT-2568-settable-mknod-intercept branch from 2da89ca to 65e8706 Compare January 16, 2025 20:16
@mattculler mattculler merged commit 6ceb498 into main Jan 16, 2025
16 checks passed
@mattculler mattculler deleted the work/CRAFT-2568-settable-mknod-intercept branch January 16, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@lengau lengau lengau approved these changes

@upils upils Awaiting requested review from upils

Assignees

@mattculler mattculler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't set security.syscalls.intercept.mknod=true for LXD provider
3 participants
@mattculler @lengau @mr-cal