Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): replace requests-unixsocket with requests-unixsocket2 #667

Merged
merged 5 commits into from
Oct 2, 2024
Merged

build(deps): replace requests-unixsocket with requests-unixsocket2 #667

merged 5 commits into from
Oct 2, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Sep 27, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

This backports the requests-unixsocket2 change to 1.20, which is used by both Snapcraft 7 and Charmcraft 2

@lengau lengau marked this pull request as ready for review October 2, 2024 17:30
@lengau lengau added the rebase Rebase-merge this PR label Oct 2, 2024
mr-cal
mr-cal reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can fix the test failures with a cherry-pick of #492, #601, and #606.

Or we can ignore them, I don't love the idea of dropping bases in a patch release. On the other hand, they are EOL'd.

@lengau
Copy link
Contributor Author

lengau commented Oct 2, 2024

@mr-cal because they're interim bases (already semi-unsupported), I think we can drop 'em. If it were an LTS base I'd be a lot more concerned.

mr-cal added 3 commits October 2, 2024 15:11
@mr-cal @lengau
chore: drop lunar (ubuntu 23.04) (#492)
f1316a6
@mr-cal @lengau
chore: drop Ubuntu 23.10 (Mantic) (#601)
6e87f6d 
Ubuntu 23.10 reached end of life on 2024-Jul-11.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal @lengau
tests: update LXD error message (#606)
51e1ac4 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@lengau lengau force-pushed the work/hotfix-1.20.4 branch from aa5b887 to 51e1ac4 Compare October 2, 2024 19:19
@lengau lengau requested a review from mr-cal October 2, 2024 20:42
@lengau lengau requested a review from a team October 2, 2024 20:49
dariuszd21
dariuszd21 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lengau lengau merged commit f09f22d into hotfix/1.20 Oct 2, 2024
13 checks passed
@lengau lengau deleted the work/hotfix-1.20.4 branch October 2, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

Assignees
No one assigned
Labels
rebase Rebase-merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @dariuszd21 @mr-cal