Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add security scan workflow #666

Merged
merged 3 commits into from
Oct 1, 2024
Merged

ci: add security scan workflow #666

merged 3 commits into from
Oct 1, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Sep 26, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau force-pushed the work/CRAFT-3373/secscan branch 2 times, most recently from f4eb92d to bbc32a0 Compare September 26, 2024 16:24
@lengau lengau force-pushed the work/CRAFT-3373/secscan branch from bbc32a0 to 56e35a7 Compare September 26, 2024 16:29
@lengau lengau requested review from mr-cal and mattculler September 27, 2024 13:58
@lengau lengau marked this pull request as ready for review September 27, 2024 13:58
mattculler
mattculler approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@mattculler mattculler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the RTD CI failure?

@lengau
Copy link
Contributor Author

lengau commented Oct 1, 2024

@mattculler there was a newer version of canonical-sphinx released that seems to have removed a dependency we used for grids.

@lengau lengau merged commit b1abe71 into main Oct 1, 2024
14 of 15 checks passed
@lengau lengau deleted the work/CRAFT-3373/secscan branch October 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @mr-cal @mattculler