-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install Ubuntu Pro Client in LXD instance #664
feat: install Ubuntu Pro Client in LXD instance #664
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/pro-sources #664 +/- ##
======================================================
Coverage ? 98.77%
======================================================
Files ? 55
Lines ? 4576
Branches ? 0
======================================================
Hits ? 4520
Misses ? 56
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@canonical/starcraft-reviewers Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Can you add test cases for the missing code coverage notices?
@mr-cal I think it's ok to address the coverage issues later on, when this feature branch is considered for merging to |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@tigarmo This is ready for merge now. |
tox
?Intsall Ubuntu Pro Client inside the managed LXD instance, which is necessary for all Pro-related commands such as attach, enable, etc.