Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install Ubuntu Pro Client in LXD instance #664

Conversation

linostar
Copy link

@linostar linostar commented Sep 25, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Intsall Ubuntu Pro Client inside the managed LXD instance, which is necessary for all Pro-related commands such as attach, enable, etc.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/pro-sources@c511987). Learn more about missing BASE report.

Files with missing lines Patch % Lines
craft_providers/lxd/lxc.py 95.34% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             feature/pro-sources     #664   +/-   ##
======================================================
  Coverage                       ?   98.77%           
======================================================
  Files                          ?       55           
  Lines                          ?     4576           
  Branches                       ?        0           
======================================================
  Hits                           ?     4520           
  Misses                         ?       56           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linostar linostar marked this pull request as ready for review September 27, 2024 12:43
@linostar
Copy link
Author

@canonical/starcraft-reviewers Ready for review.

@mr-cal mr-cal requested review from tigarmo, mr-cal and a team and removed request for a team September 27, 2024 14:16
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Can you add test cases for the missing code coverage notices?

craft_providers/lxd/lxc.py Outdated Show resolved Hide resolved
craft_providers/lxd/lxc.py Show resolved Hide resolved
@mr-cal mr-cal requested a review from a team October 1, 2024 13:21
@tigarmo
Copy link
Contributor

tigarmo commented Oct 2, 2024

@mr-cal I think it's ok to address the coverage issues later on, when this feature branch is considered for merging to main

@tigarmo tigarmo requested a review from mr-cal October 2, 2024 12:46
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@linostar
Copy link
Author

linostar commented Oct 8, 2024

@tigarmo This is ready for merge now.

@tigarmo tigarmo merged commit 09caf83 into canonical:feature/pro-sources Oct 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants