feat: split stderr for better error presentation #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bepri
commented
Nov 7, 2024
bepri
commented
- Have you signed the CLA?
Adds a fork_utils module for capturing stdout/stderr separately, while also keeping a (best-effort) temporally-accurate combined account of the two.
ForkProcess now prints to the provided stdout/stderr, or nowhere at all if fileno -1 is given
StreamHandler objects were closing their pipes before guaranteeing that their associated thread wouldn't attempt to read from them again. This commit should fix that issue.
Raise a unique exception when scripts fail, that way different caller functions can decide how to handle the failure themselves
Moves the raising of ForkError from the caller to the `run()` function itself, additionally adding a `check` parameter for skipping this exception if it should be ignored.
…tibility Most tests and other modules expect `subprocess.run()` to be called, so the kwargs passed into it are given with the expectation that they'll be handled that way. Instead of changing each call one-by-one, this commit changes `fork_utils.run()` to default to the system's stdout/stderr when given `None` instead of not redirecting output at all.
cmatsuoka
reviewed
Nov 13, 2024
tigarmo
reviewed
Nov 22, 2024
dariuszd21
reviewed
Nov 25, 2024
Co-authored-by: Dariusz Duda <dariusz.duda@canonical.com>
Co-authored-by: Dariusz Duda <dariusz.duda@canonical.com>
To speed up the program and improve code cleanliness, proper BytesIO objects should be used and the file descriptors they read from should be wrapped in a context manager that guarantees they will be closed properly. This commit addresses both statements.
dariuszd21
approved these changes
Nov 25, 2024
|
In craft-application, it was found that tests would fail if they used the |
sergiusens
reviewed
Nov 26, 2024
dariuszd21
reviewed
Nov 26, 2024
dariuszd21
approved these changes
Nov 26, 2024
sergiusens
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.