Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix explanation pages #765

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

linostar
Copy link
Contributor

  • Have you signed the CLA?

This PR is part of series of proofreading Rockcraft and Craft Parts documentation, making it up-to-date and conforming to standards, and adding/fixing sections and links where necessary.

@linostar linostar marked this pull request as ready for review June 28, 2024 12:27
@linostar
Copy link
Contributor Author

@canonical/starcraft-maintainers This is ready for review, but needs manual CI re-running.

@linostar
Copy link
Contributor Author

@cjdcordeiro FYI.

@sergiusens
Copy link
Collaborator

/home/docs/checkouts/readthedocs.org/user_builds/canonical-craft-parts/checkouts/765/docs/common/craft-parts/explanation/how_parts_are_built.rst:39: WARNING: undefined label: 'overlays'
/home/docs/checkouts/readthedocs.org/user_builds/canonical-craft-parts/checkouts/765/docs/common/craft-parts/explanation/how_parts_are_built.rst:39: WARNING: undefined label: 'overlays'

@cjdcordeiro
Copy link

are the failing tests related?

@linostar
Copy link
Contributor Author

linostar commented Jul 1, 2024

are the failing tests related?

The failing tests seem not be related. They are dpkg lock errors when running apt install commands in tests.

@tigarmo tigarmo requested a review from cmatsuoka July 2, 2024 17:20
docs/common/craft-parts/explanation/overlays.rst Outdated Show resolved Hide resolved
docs/common/craft-parts/explanation/parts.rst Outdated Show resolved Hide resolved
docs/common/craft-parts/explanation/parts.rst Outdated Show resolved Hide resolved
docs/common/craft-parts/reference/part_properties.rst Outdated Show resolved Hide resolved
Copy link

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests are unrelated

@linostar
Copy link
Contributor Author

linostar commented Jul 4, 2024

LGTM if the tests are unrelated

They are unrelated.
That being said, it is not clear to me what is causing those dpkg lock errors.

@lengau lengau merged commit 2ae355d into canonical:main Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants