fix: [PROTOTYPE] add option to use symlinks with the npm plugin #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bepri
commented
Feb 4, 2025
craft_parts/plugins/npm_plugin.py
Outdated
| @@ -301,11 +314,12 @@ def get_build_commands(self) -> list[str]: | |||
| cmd += [ | |||
| dedent( | |||
| f"""\ | |||
| tar -xzf "{self._node_binary_path}" -C "${{CRAFT_PART_INSTALL}}/" \ | |||
| tar -hxzf "{self._node_binary_path}" -C "${{CRAFT_PART_INSTALL}}/" \ | |||
There was a problem hiding this comment.
tar -h avoids overwriting symlinks at the location, instead following them when unpacking a tarball
bepri
commented
Feb 4, 2025
There was a problem hiding this comment.
Much of the diff in this file was a refactor to deduplicate code into a fixture, the tests themselves are unchanged
bepri
force-pushed
the
work/npm-plugin-symlinks/CRAFT-4071
branch
from
e33ee74 to
f347293
Compare
bepri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/reference/changelog.rst)?