Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo: permit file URLs #93

Merged
merged 2 commits into from
Jul 3, 2023
Merged

repo: permit file URLs #93

merged 2 commits into from
Jul 3, 2023

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jun 30, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Fixes #92

@lengau
repo: permit file URLs
4d0b0af 
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@lengau lengau requested a review from tigarmo June 30, 2023 21:58
@lengau
repo: permit file URLs
83daa4a 
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Merging #93 (83daa4a) into main (be875b0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          13       13           
  Lines         687      687           
  Branches      140      140           
=======================================
  Hits          619      619           
  Misses         50       50           
  Partials       18       18
Impacted Files Coverage Δ
craft_archives/repo/package_repository.py 98.76% <100.00%> (ø)

tigarmo
tigarmo approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lengau lengau merged commit 6f787ea into main Jul 3, 2023
@lengau lengau deleted the aml/url branch July 3, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"url" field no longer accepts local paths
2 participants
@lengau @tigarmo