-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo: install package repositories in "arbitrary" paths #80
Conversation
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 88.17% 87.86% -0.31%
==========================================
Files 13 13
Lines 634 659 +25
Branches 125 131 +6
==========================================
+ Hits 559 579 +20
- Misses 61 66 +5
Partials 14 14
|
This commit adds a new public function, "install_in_root()", that installs package repositories in a location that contains an Apt-based system, and _not_ the host system. The intention is that eventually said system will be chroot'ed into, at which point an "apt update" will pick up the new repositories. The motivation is to support package repositories in overlays in Rockcraft.
0bae11f
to
326a808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good, I would make the doc updates though
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
This commit adds a new public function, "install_in_root()", that installs package repositories in a location that contains an Apt-based system, and not the host system. The intention is that eventually said system will be chroot'ed into, at which point an "apt update" will pick up the new repositories.
The motivation is to support package repositories in overlays in Rockcraft.
tox
?