Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: fix bad typing_extensions interaction #78

Merged
merged 2 commits into from
May 23, 2023

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented May 23, 2023

Ref: pydantic/pydantic#5821 (comment)
We could also pin typing_extensions to 4.5.0 instead, but those pins have a tendency of sticking around.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Ref: pydantic/pydantic#5821 (comment)

We could also pin typing_extensions to 4.5.0 instead, but those pins
have a tendency of sticking around.
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #78 (fcaf90f) into main (fd9fac8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   88.09%   88.11%   +0.01%     
==========================================
  Files          13       13              
  Lines         630      631       +1     
  Branches      125      125              
==========================================
+ Hits          555      556       +1     
  Misses         61       61              
  Partials       14       14              
Impacted Files Coverage Δ
craft_archives/repo/package_repository.py 98.76% <100.00%> (+<0.01%) ⬆️

@tigarmo tigarmo requested a review from lengau May 23, 2023 14:49
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is the best option. Thanks for fixing it!

Could you put a comment linking either this PR or the pydantic issue so we know why we used typing_extensions (and we know we can eliminate it once we don't have to support anything older than Python 3.10)?

@tigarmo
Copy link
Collaborator Author

tigarmo commented May 23, 2023

@lengau sure, done! Might have gone overboard with the comment maybe heh

@tigarmo tigarmo merged commit 7407d1d into canonical:main May 23, 2023
@tigarmo tigarmo deleted the fix-typing-extensions branch May 23, 2023 18:11
tigarmo pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants