Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: replace os_release.py with distro package #59

Merged
merged 1 commit into from
May 22, 2023

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented May 19, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Tested with snapcraft: canonical/snapcraft#4155
Tested with rockcraft: canonical/rockcraft#268

Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@lengau lengau changed the title util: replace os_release.py with ditsro package util: replace os_release.py with distro package May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #59 (3564016) into main (09032a8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   88.07%   88.09%   +0.01%     
==========================================
  Files          13       13              
  Lines         629      630       +1     
  Branches      125      125              
==========================================
+ Hits          554      555       +1     
  Misses         61       61              
  Partials       14       14              
Impacted Files Coverage Δ
craft_archives/repo/apt_sources_manager.py 93.40% <100.00%> (+0.07%) ⬆️

@lengau lengau marked this pull request as ready for review May 19, 2023 05:07
@lengau lengau requested a review from tigarmo May 19, 2023 05:07
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

tigarmo pushed a commit to tigarmo/craft-archives that referenced this pull request May 20, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@sergiusens sergiusens merged commit 0d2ba14 into canonical:main May 22, 2023
@lengau lengau deleted the distro branch May 22, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants