Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix typing issues with updated pyright #58

Merged
merged 2 commits into from
May 18, 2023

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented May 18, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@lengau lengau closed this May 18, 2023
@lengau lengau reopened this May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #58 (99f388a) into main (c9bd220) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   88.01%   88.05%   +0.03%     
==========================================
  Files          13       13              
  Lines         626      628       +2     
  Branches      125      124       -1     
==========================================
+ Hits          551      553       +2     
  Misses         61       61              
  Partials       14       14              
Impacted Files Coverage Δ
craft_archives/repo/apt_ppa.py 91.30% <100.00%> (ø)
craft_archives/repo/package_repository.py 98.75% <100.00%> (+0.01%) ⬆️
craft_archives/repo/projects.py 100.00% <100.00%> (ø)

Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@lengau lengau requested a review from tigarmo May 18, 2023 19:37
@sergiusens sergiusens merged commit 7983916 into canonical:main May 18, 2023
@lengau lengau deleted the update-pyright branch May 19, 2023 00:06
tigarmo pushed a commit to tigarmo/craft-archives that referenced this pull request May 20, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants