Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #53

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Fix typos #53

merged 2 commits into from
Apr 5, 2023

Conversation

dboddie
Copy link
Contributor

@dboddie dboddie commented Apr 3, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tigarmo
Copy link
Collaborator

tigarmo commented Apr 4, 2023

Weird, I updated the branch with a rebase and one of the commits is gone (the one adding the intro on the docs' front page). @dboddie did you by any chance remove it?

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #53 (6593c7a) into main (4cedf37) will decrease coverage by 1.49%.
The diff coverage is n/a.

❗ Current head 6593c7a differs from pull request most recent head a6c2c4d. Consider uploading reports for the commit a6c2c4d to get more accurate results

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   83.96%   82.48%   -1.49%     
==========================================
  Files          13       12       -1     
  Lines         786      685     -101     
  Branches      182      157      -25     
==========================================
- Hits          660      565      -95     
+ Misses         89       88       -1     
+ Partials       37       32       -5     

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dboddie
Copy link
Contributor Author

dboddie commented Apr 5, 2023

Weird, I updated the branch with a rebase and one of the commits is gone (the one adding the intro on the docs' front page). @dboddie did you by any chance remove it?

It might be that I had the same commit in two branches and it was already committed in #31.

@tigarmo tigarmo enabled auto-merge (squash) April 5, 2023 13:27
@tigarmo tigarmo merged commit bc08456 into canonical:main Apr 5, 2023
@dboddie dboddie deleted the fix-typos branch April 17, 2023 09:21
tigarmo pushed a commit to tigarmo/craft-archives that referenced this pull request May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants