Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: set home dir when importing keys to show #51

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Mar 24, 2023

Unlike --show-keys, --import with --import-options show-only needs a directory to place the temporarily imported key; If not provided, gpg will default to ~/.gnupg, creating it if necessary. This creation can be a race when running tests in parallel, as multiple gpg processes try to create ~/.gnupg simultaneously.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Unlike `--show-keys`, `--import` with `--import-options show-only` needs
a directory to place the temporarily imported key; If not provided, gpg
will default to ~/.gnupg, creating it if necessary. This creation can
be a race when running tests in parallel, as multiple gpg processes try
to create ~/.gnupg simultaneously.
@tigarmo tigarmo marked this pull request as ready for review March 24, 2023 14:18
@tigarmo tigarmo requested a review from lengau March 24, 2023 14:18
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #51 (f21ecba) into main (d453e83) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   82.32%   82.48%   +0.15%     
==========================================
  Files          12       12              
  Lines         679      685       +6     
  Branches      154      157       +3     
==========================================
+ Hits          559      565       +6     
  Misses         88       88              
  Partials       32       32              
Impacted Files Coverage Δ
craft_archives/repo/apt_key_manager.py 98.11% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm happy with whatever you decide about the return type comment.

@tigarmo tigarmo merged commit f69dfee into canonical:main Mar 24, 2023
@tigarmo tigarmo deleted the disable-gnupg-homedir branch March 24, 2023 20:41
tigarmo pushed a commit to tigarmo/craft-archives that referenced this pull request May 20, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants