Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: handle keyring path parents not existing #50

Merged
merged 10 commits into from
May 19, 2023

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Mar 23, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

This is needed for canonical/rockcraft#217

Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@lengau lengau requested a review from tigarmo March 23, 2023 23:46
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #50 (d34b469) into main (7983916) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   88.05%   88.07%   +0.01%     
==========================================
  Files          13       13              
  Lines         628      629       +1     
  Branches      124      125       +1     
==========================================
+ Hits          553      554       +1     
  Misses         61       61              
  Partials       14       14              
Impacted Files Coverage Δ
craft_archives/repo/apt_key_manager.py 98.21% <100.00%> (+0.01%) ⬆️

@lengau lengau requested a review from tigarmo April 16, 2023 15:38
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@sergiusens sergiusens merged commit 09032a8 into canonical:main May 19, 2023
@lengau lengau deleted the ppa-keyrings branch May 19, 2023 00:05
tigarmo pushed a commit to tigarmo/craft-archives that referenced this pull request May 20, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants