Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to pydantic 2.x #103

Merged
merged 4 commits into from
Jun 5, 2024
Merged

feat: upgrade to pydantic 2.x #103

merged 4 commits into from
Jun 5, 2024

Conversation

linostar
Copy link

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@linostar linostar marked this pull request as draft December 14, 2023 16:12
@linostar linostar mentioned this pull request Dec 14, 2023
Closed
3 tasks
@linostar linostar force-pushed the ROCKS-918/feat/upgrade-to-pydantic-2.x branch 17 times, most recently from cfc9762 to cc218d6 Compare January 11, 2024 13:12
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/2.0@9f73ab6). Learn more about missing BASE report.

❗ Current head 920be5f differs from pull request most recent head 87dd06f

Please upload reports for the commit 87dd06f to get more accurate results.

Additional details and impacted files 
@@              Coverage Diff               @@
##             feature/2.0     #103   +/-   ##
==============================================
  Coverage               ?   90.20%           
==============================================
  Files                  ?       13           
  Lines                  ?      694           
  Branches               ?      163           
==============================================
  Hits                   ?      626           
  Misses                 ?       50           
  Partials               ?       18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linostar linostar marked this pull request as ready for review January 11, 2024 13:14
@linostar
Copy link
Author

@cjdcordeiro Ready for review.

@linostar linostar force-pushed the ROCKS-918/feat/upgrade-to-pydantic-2.x branch from cc218d6 to 567d54a Compare January 11, 2024 14:13
@linostar linostar force-pushed the ROCKS-918/feat/upgrade-to-pydantic-2.x branch from 567d54a to 6bea7cf Compare January 11, 2024 14:40
@linostar linostar mentioned this pull request Jan 11, 2024
Closed
3 tasks
@cjdcordeiro
Copy link

cjdcordeiro commented Jan 23, 2024 •
edited
Loading

@cjdcordeiro Ready for review.

This is better suited for @cmatsuoka and @tigarmo to review (although at a quick glance, I don't have any major comments)

tigarmo
tigarmo reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm reluctant to put this in main, I think we might add a feature/pydantic2 branch in this and the other libs to use as a temporary place to hold the work

craft_archives/repo/package_repository.py Show resolved Hide resolved
craft_archives/repo/package_repository.py Outdated Show resolved Hide resolved
@tigarmo tigarmo requested a review from cmatsuoka January 23, 2024 17:54
@linostar linostar requested a review from tigarmo January 25, 2024 07:01
@lengau lengau changed the base branch from main to feature/2.0 May 22, 2024 19:03
lengau
lengau approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some minor suggestions, but we can pull this in as-is too. I've also targeted a new branch for all the changes we want to make in craft-archives 2.0.

craft_archives/repo/package_repository.py Show resolved Hide resolved
pyproject.toml
@@ -7,7 +7,7 @@ dependencies = [
"lazr.restfulclient",
"lazr.uri",
"overrides",
"pydantic<2.0.0",
"pydantic>=2.0.0,<3.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pydantic>=2.0.0,<3.0.0",
"pydantic~=2.0",

pyproject.toml Show resolved Hide resolved
@lengau lengau linked an issue May 22, 2024 that may be closed by this pull request
Migrate to Pydantic 2 #110
Closed
@lengau lengau added this to the 2.0 milestone May 22, 2024
cmatsuoka
cmatsuoka approved these changes Jun 4, 2024
View reviewed changes
Copy link

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lengau
Copy link
Collaborator

lengau commented Jun 5, 2024

Thanks for all this work @linostar !

I've taken the remaining comments and merged them into an issue here: #118

@lengau lengau merged commit b69f44a into canonical:feature/2.0 Jun 5, 2024
6 checks passed
@lengau lengau mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@tigarmo tigarmo tigarmo approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Migrate to Pydantic 2
5 participants
@linostar @cjdcordeiro @lengau @cmatsuoka @tigarmo