Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch to starflow #622

Merged
merged 16 commits into from
Feb 7, 2025
Merged

build: switch to starflow #622

merged 16 commits into from
Feb 7, 2025

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Jan 29, 2025

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau changed the title build: add starbase Makefiles and qa workflow build: switch to starflow Jan 31, 2025
@lengau lengau force-pushed the work/starflow branch 8 times, most recently from 037704b to 6424463 Compare February 4, 2025 17:13
@lengau lengau requested review from mr-cal and bepri February 4, 2025 18:20
@lengau lengau marked this pull request as ready for review February 4, 2025 18:20
Copy link
Contributor

@bepri bepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Always nice to have more stuff on Starflow/Starbase.

Aside from the comments I'm leaving below, there's also a general one: "tox" (as a string) still appears in three files: .gitignore, HACKING.rst, and pyproject.toml. Could you remove those references to tox, or replace them with their modern equivalents?

Makefile Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@lengau lengau requested a review from bepri February 4, 2025 21:15
Makefile Outdated Show resolved Hide resolved
@lengau lengau force-pushed the work/starflow branch 2 times, most recently from 2962b46 to ea1ed13 Compare February 6, 2025 21:24
@lengau
Copy link
Contributor Author

lengau commented Feb 6, 2025

@sergiusens we need your super admin powers on this please. The 3 pending checks need to be removed as mandatory with the following added:

  • lint / files
  • tests / Fast tests (noble, amd64)
  • tests / Slow tests (noble, amd64, 3.12)

Once that's done we should be clear to rebase & merge

@lengau lengau added the rebase label Feb 6, 2025
@lengau lengau merged commit 0a12711 into main Feb 7, 2025
16 checks passed
@lengau lengau deleted the work/starflow branch February 7, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants