feat: use platform name in build instance name #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/CRAFT-3859-platform-in-name
branch
from
ed273d0 to
2d776a3
Compare
|
Integration test failure looks unrelated, something is going on with launchpad. https://api.staging.launchpad.net/devel/people/+me isn't responding |
mr-cal
commented
Jan 9, 2025
lengau
reviewed
Jan 9, 2025
3 tasks
mr-cal
force-pushed
the
work/CRAFT-3859-platform-in-name
branch
2 times, most recently
from
4d20752 to
d93c378
Compare
|
forced push to bump craft-providers and prep for a rebase |
mr-cal
force-pushed
the
work/CRAFT-3859-platform-in-name
branch
from
d93c378 to
7e165b1
Compare
|
blocked by #603 |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
This ensures each platform is built in its own build environment. Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/CRAFT-3859-platform-in-name
branch
from
7e165b1 to
ca8a159
Compare
|
force-pushing to update date in changelog and prep for rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Changes the build instance name to use the platform rather than the
build-onandbuild-forarchitectures.This prevents the same build environment being used for multiple platforms. See canonical/charmcraft#2069 for examples.
Fixes #600
Unblocks canonical/charmcraft#2069
(CRAFT-3859)