Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the version that was forgotten in #48 #50

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Bump the version that was forgotten in #48 #50

merged 1 commit into from
Aug 15, 2024

Conversation

mmkay
Copy link
Contributor

@mmkay mmkay commented Aug 14, 2024

In #48 I forgot to bump the version. It should happen.

@mmkay mmkay requested a review from a team as a code owner August 14, 2024 20:52
@mmkay mmkay merged commit d19ae2a into main Aug 15, 2024
5 checks passed
@mmkay mmkay deleted the fix/vbump branch August 15, 2024 06:52
PietroPasotti added a commit that referenced this pull request Aug 26, 2024
* Catch SecretNotFoundError when privkey shouldn't be here (#48)

* Catch SecretNotFoundError when privkey shouldn't be here

* Bring back if self.tls_available check from pre-refactor times

* lint

* Bump the version that was forgotten in #48 (#50)

* Add issues integration action (#52)

* Add issues integration action

* Order imports differently as lint started to complain

* Update databag model dump return value (#53)

* dump returns databag

* tests

* root ca cert patch

* fixed static checks

* fix

* removed conftest

* added health check logic to worker (#55)

* added health check logic to worker

* adapted status check to be less tempo-specific

* use regular paths for codespell too

* rerun black

* vbump

* added worker error on timeout if restart fails (#56)

* added worker error on timeout if restart fails

* maintenance status throughout retries

* fixed static

* only restart own services

* added tls support for worker checks (#59)

* added tls support for worker checks

* lint

* static fix

* Test coordinator (#60)

* Added the following:
1) Coordinator pytest fixtures
2) Coordinator unit tests
3) Rrefactoring of roles_config in coordinator.py
  * ClusterRolesConfig was switched to a dataclass with __post_init__ and is_coherent_with methods
4) Created test_roles_config.py tests

* Chore: Fix leftover comments and minor code changes

* * Updates
1) Fmt
2) Merged 'main:coordinator.py' into test-coordinator-cleanup to fix Secrets error

* Added docstrings to ClusterRoleConfig

---------

Co-authored-by: Mateusz Kulewicz <mateusz.kulewicz@canonical.com>
Co-authored-by: PietroPasotti <starfire.daemon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants