Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap: refresh for core24 #37

Merged
merged 3 commits into from
May 6, 2024
Merged

snap: refresh for core24 #37

merged 3 commits into from
May 6, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Apr 15, 2024

No description provided.

@Saviq Saviq force-pushed the core24 branch 4 times, most recently from a5f1830 to b7e6cc8 Compare April 15, 2024 11:47
@Saviq Saviq force-pushed the core24 branch 5 times, most recently from 2b961e8 to 143bd35 Compare April 15, 2024 14:06
@Saviq Saviq force-pushed the core24 branch 4 times, most recently from c25cbb4 to 1744f3e Compare April 24, 2024 14:47
@Saviq Saviq added the no merge Not suitable for merging label Apr 24, 2024
@Saviq Saviq marked this pull request as ready for review April 24, 2024 15:42
@Saviq Saviq requested a review from a team as a code owner April 24, 2024 15:42
@Saviq Saviq requested a review from AlanGriffiths April 24, 2024 15:42
AlanGriffiths
AlanGriffiths approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane (apart from the "tweak", which isn't our insanity)

@Saviq Saviq removed the no merge Not suitable for merging label May 6, 2024
@Saviq Saviq mentioned this pull request May 6, 2024
Merged
6 tasks
AlanGriffiths
AlanGriffiths approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What could go wrong?

@AlanGriffiths AlanGriffiths added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 47af572 May 6, 2024
3 checks passed
@AlanGriffiths AlanGriffiths deleted the core24 branch May 6, 2024 14:11
github-merge-queue bot pushed a commit to canonical/mir-ci that referenced this pull request May 7, 2024
@AlanGriffiths
snaps: switch over to base: core24 (#121)
669873f 
This should only land after:
- [x] canonical/confined-shell-wip#37
- [x] canonical/ubuntu-frame#177
- [x] Miriway/Miriway#94
- [x] canonical/ubuntu-frame-osk#73
- [x] canonical/ubuntu-frame-vnc#20
- [x] canonical/mir#3364
Saviq pushed a commit to canonical/mir-ci that referenced this pull request Jan 10, 2025
@AlanGriffiths @Saviq
snaps: switch over to base: core24 (#121)
8048809 
This should only land after:
- [x] canonical/confined-shell-wip#37
- [x] canonical/ubuntu-frame#177
- [x] Miriway/Miriway#94
- [x] canonical/ubuntu-frame-osk#73
- [x] canonical/ubuntu-frame-vnc#20
- [x] canonical/mir#3364
Saviq pushed a commit to canonical/mir-ci that referenced this pull request Jan 10, 2025
@AlanGriffiths @Saviq
snaps: switch over to base: core24 (#121)
4fed33c 
This should only land after:
- [x] canonical/confined-shell-wip#37
- [x] canonical/ubuntu-frame#177
- [x] Miriway/Miriway#94
- [x] canonical/ubuntu-frame-osk#73
- [x] canonical/ubuntu-frame-vnc#20
- [x] canonical/mir#3364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saviq @AlanGriffiths