chore: cleanup `len' usage #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheRealFalcon @blackboxsw PTAL and let me what you think of this. |
|
@TheRealFalcon gentle reminder on this. If you think this is a big change for little gain, please let me know; I will close this PR. |
|
@sshedi , sorry, I've been busy with some other priorities. It is a big change, but I think it's probably worthwhile. I just need to get some time to review. |
No rush at all—I just wanted to check if this change is worth making. Sorry to bother you, and thanks! |
TheRealFalcon
requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks @sshedi , the changes here generally look good to me. I left some inline comments
In most cases there is need to calculate length of list of string values to do something else, just ensuring list or string is not empty is enough. This will also give a slight performance gain. Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
TheRealFalcon
approved these changes
Feb 5, 2025
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 11, 2025
In most cases there is no need to calculate length of list of string values to do something else, just ensuring list or string is not empty is enough. This will also give a slight performance gain. Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Feb 11, 2025
In most cases there is no need to calculate length of list of string values to do something else, just ensuring list or string is not empty is enough. This will also give a slight performance gain. Signed-off-by: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases there is need to calculate length of list of string values to do something else, just ensuring list or string is not empty is enough. This will also give a slight performance gain.
Proposed Commit Message
Merge type