Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Retry enhancement in OpenStack batch creation scenarios #5943

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

gglzf4
Copy link
Contributor

@gglzf4 gglzf4 commented Dec 26, 2024

[enhancement]: Retry enhancement in OpenStack batch creation scenarios

When obtaining OpenStack metadata
the HTTP status of 5xx indicates a server exception and should be retried


Fixes GH-5687

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb
Copy link
Member

holmanb commented Jan 6, 2025

Welcome @gglzf4! Please sign the CLA.

add gglzf4 to .github-cla-signers
@gglzf4
Copy link
Contributor Author

gglzf4 commented Jan 7, 2025

Welcome @gglzf4! Please sign the CLA.

Thank you. I'll sign it right away.

cloudinit/sources/helpers/openstack.py Outdated Show resolved Hide resolved
@holmanb holmanb self-assigned this Jan 7, 2025
gglzf4 added 3 commits January 8, 2025 09:30
Alphabetical order
HTTP status code >= 400 does not support retry is too general.
HTTP Retry Status [408, 429, 500, 502, 503, 504]
@gglzf4
Copy link
Contributor Author

gglzf4 commented Jan 10, 2025

The HTTP status code >= 400 does not support retry is too general. Retry should be supported for the following HTTP status codes:
408 Request Timeout
429 Too Many Requests
500 Internal Server Error
502 Bad Gateway
503 Service Unavailable
504 Gateway Timeout

Please help review it! @holmanb @TheRealFalcon

Copy link

github-actions bot commented Feb 2, 2025

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Feb 2, 2025
@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Feb 7, 2025
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gglzf4. This looks good to me!

@holmanb holmanb merged commit b860d70 into canonical:main Feb 7, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants