-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Skip package build on tox runs #5210
Conversation
Building a wheel/sdist generally adds 5+ seconds to every tox run. This is unnecessary because a built package isn't needed to run any of the CI tasks. Also remove the `recreate` line as it wasn't doing anything. To work correctly, it should be defined under `[testenv]`, not `[tox]`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea. We won't exercise package build as much as a result, but I don't see that as a loss. We do that in the CI integration job, and plenty in our integration tests too.
Maybe give other other devs a chance to object before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's try this out to ease the time costs of CI and local tox runs to cut down on the recurring cost of development and testing. While I like that our CI tests happen to exercise the package build, We can easily run any of the following on PRs that happen to be packaging related
make deb
./packages/bbdeb -S
- or
tox --override testenv.package=wheel
or something to validate no degradation in behavior on those branches
Commit acc68de introduced a change which no longer builds a wheel, however integration tests now fail when dependencies are not available. Include the base requirements in test-requirements.txt. Fixes canonicalGH-5210
Proposed Commit Message
Additional Context
tox -e ruff
is near instant on Python 3.8+recreate
lives under https://tox.wiki/en/latest/config.html#tox-environmentTest Steps
Checklist
Merge type