Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add subnet ipv4/ipv6 to network schema #5191

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

TheRealFalcon
Copy link
Member

@TheRealFalcon TheRealFalcon commented Apr 18, 2024

Proposed Commit Message

fix: Add subnet ipv4/ipv6  to network schema

These are used by our openstack network_data.json parsing code and
get used by the sysconfig renderer.

Fixes GH-4911

Additional Context

#4911
and

is_ipv6 = subnet.get("ipv6") or is_ipv6_address(
route["gateway"]
)
# Any dynamic configuration method, slaac, dhcpv6-stateful/
# stateless should get router information from router RA's.
if (
_is_default_route(route)
and subnet_type not in IPV6_DYNAMIC_TYPES
):
if (
subnet.get("ipv4") and route_cfg.has_set_default_ipv4
) or (
subnet.get("ipv6") and route_cfg.has_set_default_ipv6

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

These are used by our openstack network_data.json parsing code and
get used by the sysconfig renderer.

Fixes canonicalGH-4911
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost tempted to ask if we can reorder that config change to after validation rather than supporting this as a user-facing config option for one (not used anymore?) renderer, but I haven't looked to see how difficult that would be.

Either way, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants