docs: Add breaking datasource identification changes

[TheRealFalcon]

Proposed Commit Message

docs: Add breaking datasource identification changes

Merge type

• Squash merge using "Proposed Commit Message"
• Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

[catmsred]

Can we put 24.1 at the top, so the read order is most recent version first since that is how the larger page organization goes?

[TheRealFalcon]

Can we put 24.1 at the top

I think that depends if we want to prioritize consistency or readability. The later changes are a direct result of the one before it, so I think it's harder understanding why the changes happened when we put them in reverse chronological order.

If you don't see it is a big hindrance, I'm fine reordering them.

[catmsred]

Can we put 24.1 at the top

I think that depends if we want to prioritize consistency or readability. The later changes are a direct result of the one before it, so I think it's harder understanding why the changes happened when we put them in reverse chronological order.

If you don't see it is a big hindrance, I'm fine reordering them.

Good point. Maybe have the header title include the affected versions, e.g. 23.2-24.1 Datasource identification and then leave the subheadings as is?

Another option is to reorganize the page to run oldest to newest.

[holmanb]

Thanks for the content @TheRealFalcon. It mostly looks good. I have a couple of minor change requests in line.

[holmanb]

This only holds true when the datasource_list that is provided under /etc/cloud/ has a length of 1, right? Can we please clarify that?

[holmanb]

nit: also this subsection is declarative while the others are imperative which feels awkward "will no longer" vs "no longer"

[holmanb]

Grouping these is useful, but it doesn't fit with the existing content since the header Datasource identification isn't ordered while the existing content is. Perhaps something like @catmsred's suggestion 23.2-24.1 Datasource identification would resolve that?

[TheRealFalcon]

Updated based on comments. Let me know if this new heading looks any better.

[holmanb]

Updated based on comments. Let me know if this new heading looks any better.

I'm fine with it. @catmsred?

[holmanb]

Thanks again @TheRealFalcon!

[catmsred]

Looks good to me!