Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix upgrade dhcp6 on ec2 #5131

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Apr 2, 2024

Proposed Commit Message

After [0, 1], dhcp6 is going to be always false after upgrading cloud-init. Correct this in the integration test.

Refs:
[0] https://github.com/canonical/cloud-init/issues/3980
[1] https://bugs.launchpad.net/cloud-init/+bug/1976526

Additional Context

https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-ec2/411/testReport/junit/tests.integration_tests/test_upgrade/test_clean_boot_of_upgraded_package/

Test Steps

export CLOUD_INIT_PLATFORM=ec2
export CLOUD_INIT_CLOUD_INIT_SOURCE=ppa:cloud-init-dev/daily

tox -e integration-tests -- -vvv tests/integration_tests/test_upgrade.py::test_clean_boot_of_upgraded_package

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

After [0, 1], dhcp6 is going to be always false after upgrading
cloud-init. Correct this in the integration test.

Refs:
[0] canonical#3980
[1] https://bugs.launchpad.net/cloud-init/+bug/1976526
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aciba90!

@holmanb holmanb merged commit 9758673 into canonical:main Apr 2, 2024
28 checks passed
@aciba90 aciba90 deleted the int-ec2-dhcp6 branch April 3, 2024 06:27
holmanb pushed a commit that referenced this pull request Apr 3, 2024
After [0, 1], dhcp6 is going to be always false after upgrading
cloud-init. Correct this in the integration test.

Refs:
[0] #3980
[1] https://bugs.launchpad.net/cloud-init/+bug/1976526
holmanb pushed a commit that referenced this pull request Apr 3, 2024
After [0, 1], dhcp6 is going to be always false after upgrading
cloud-init. Correct this in the integration test.

Refs:
[0] #3980
[1] https://bugs.launchpad.net/cloud-init/+bug/1976526
holmanb pushed a commit that referenced this pull request Apr 3, 2024
After [0, 1], dhcp6 is going to be always false after upgrading
cloud-init. Correct this in the integration test.

Refs:
[0] #3980
[1] https://bugs.launchpad.net/cloud-init/+bug/1976526
aciba90 added a commit to aciba90/cloud-init that referenced this pull request Apr 5, 2024
holmanb pushed a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants