Netops refactor #5117
Merged
Netops refactor #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjp256 I think that you originally requested the iproute2 refactor to be multi-line for easier reading? Would you mind reviewing this commit which contains that change? |
holmanb
force-pushed
the
holmanb/netops-refactor
branch
3 times, most recently
from
343f2b8 to
dbe1243
Compare
holmanb
force-pushed
the
holmanb/netops-refactor
branch
from
dbe1243 to
b32fdcc
Compare
cjp256
approved these changes
Mar 29, 2024
aciba90
approved these changes
Apr 8, 2024
Various different activators, datasources, and networking code implementations make use of manual iproute2 calls, which has led to much code duplication in the codebase. This is a small step towards replacing distro assumptions at call sites with common interfaces, which will simplify future refactors for more distro-agnostic code. These same abstractions will also enable simpler testing.
holmanb
force-pushed
the
holmanb/netops-refactor
branch
from
9195ba9 to
4d91563
Compare
Done, thanks for the review @aciba90! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
This is a small step towards making cloud-init use reusable networking interfaces for better cross-distro abstractions and easier maintenance.
Merge type