Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include DataSourceCloudStack attribute in unpickle test #5039

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: Include DataSourceCloudStack attribute in unpickle test #5039

merged 1 commit into from
Mar 11, 2024

Conversation

TheRealFalcon
Copy link
Member

@TheRealFalcon TheRealFalcon commented Mar 11, 2024 •
edited
Loading

Proposed Commit Message

fix: Include DataSourceCloudStack attribute in unpickle test

Ensure  `metadata_address` is ignored in the _unpickle test for
DataSourceCloudStack. It has existed for many years.

Additional Context

Tested that it also works on the 24.1.x branch

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon
fix: Include DataSourceCloudStack attribute in unpickle test
231013a 
Ensure  is ignored in the _unpickle test for
DataSourceCloudStack. It has existed for many years.
@holmanb holmanb self-assigned this Mar 11, 2024
holmanb
holmanb approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheRealFalcon TheRealFalcon merged commit 9c64aba into canonical:main Mar 11, 2024
28 checks passed
@TheRealFalcon TheRealFalcon deleted the fixCloudStack2 branch March 11, 2024 18:32
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Mar 11, 2024
@TheRealFalcon @holmanb
fix: Include DataSourceCloudStack attribute in unpickle test (canonic…
6edf1b6 
…al#5039)

Ensure `metadata_address` is ignored in the _unpickle test for
DataSourceCloudStack. It has existed for many years.
holmanb pushed a commit that referenced this pull request Mar 11, 2024
@TheRealFalcon @holmanb
fix: Include DataSourceCloudStack attribute in unpickle test (#5039)
2a4c0b6 
Ensure `metadata_address` is ignored in the _unpickle test for
DataSourceCloudStack. It has existed for many years.
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Mar 12, 2024
@TheRealFalcon @holmanb
fix: Include DataSourceCloudStack attribute in unpickle test (canonic…
6de51c8 
…al#5039)

Ensure `metadata_address` is ignored in the _unpickle test for
DataSourceCloudStack. It has existed for many years.
holmanb pushed a commit that referenced this pull request Mar 12, 2024
@TheRealFalcon @holmanb
fix: Include DataSourceCloudStack attribute in unpickle test (#5039)
7e5caad 
Ensure `metadata_address` is ignored in the _unpickle test for
DataSourceCloudStack. It has existed for many years.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

Assignees

@holmanb holmanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealFalcon @holmanb