Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: Add ProvisionGuestProxyAgent Boolean setting #4860

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented Feb 7, 2024

Add ProvisionGuestProxyAgent Boolean configuration setting into the OvfEnv class.
This PR is only logging the value of ProvisionGuestProxyAgent.

@KsenijaS KsenijaS marked this pull request as draft February 7, 2024 22:46
@KsenijaS KsenijaS marked this pull request as ready for review February 8, 2024 19:06
@KsenijaS
Copy link
Contributor Author

KsenijaS commented Feb 8, 2024

cloud-init log snippet when proxy-guest-agent is enabled:
2024-02-08 01:03:25,691 - azure.py[INFO]: PreprovisionedVm: False
2024-02-08 01:03:25,691 - azure.py[INFO]: PreprovisionedVMType: None
2024-02-08 01:03:25,691 - azure.py[INFO]: ProvisionGuestProxyAgent: true
2024-02-08 01:03:25,692 - handlers.py[DEBUG]: finish: azure-ds/read_azure_ovf: SUCCESS: read_azure_ovf

cloud-init log when proxy-guest-agent is not enabled in the vm:
2024-02-07 23:36:58,625 - azure.py[INFO]: PreprovisionedVm: False
2024-02-07 23:36:58,625 - azure.py[INFO]: PreprovisionedVMType: None
2024-02-07 23:36:58,626 - azure.py[INFO]: ProvisionGuestProxyAgent: False
2024-02-07 23:36:58,626 - handlers.py[DEBUG]: finish: azure-ds/read_azure_ovf: SUCCESS: read_azure_ovf

Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheRealFalcon TheRealFalcon self-assigned this Feb 9, 2024
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit 7ed89d3 into canonical:main Feb 9, 2024
29 checks passed
blackboxsw pushed a commit that referenced this pull request Feb 15, 2024
Add ProvisionGuestProxyAgent Boolean configuration setting into the OvfEnv class.
This PR is only logging the value of ProvisionGuestProxyAgent.
blackboxsw pushed a commit that referenced this pull request Feb 15, 2024
Add ProvisionGuestProxyAgent Boolean configuration setting into the OvfEnv class.
This PR is only logging the value of ProvisionGuestProxyAgent.
blackboxsw pushed a commit that referenced this pull request Feb 16, 2024
Add ProvisionGuestProxyAgent Boolean configuration setting into the OvfEnv class.
This PR is only logging the value of ProvisionGuestProxyAgent.
blackboxsw pushed a commit that referenced this pull request Feb 16, 2024
Add ProvisionGuestProxyAgent Boolean configuration setting into the OvfEnv class.
This PR is only logging the value of ProvisionGuestProxyAgent.
cjp256 pushed a commit to cjp256/cloud-init that referenced this pull request Jul 11, 2024
Add ProvisionGuestProxyAgent Boolean configuration setting into the OvfEnv class.
This PR is only logging the value of ProvisionGuestProxyAgent.
KsenijaS added a commit to KsenijaS/cloud-init that referenced this pull request Jul 16, 2024
Add ProvisionGuestProxyAgent Boolean configuration setting into the OvfEnv class.
This PR is only logging the value of ProvisionGuestProxyAgent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants