add expected dhcp6 key #4855
add expected dhcp6 key #4855
Conversation
holmanb
force-pushed
the
holmanb/dhcp6-fix
branch
2 times, most recently
from
2ce55b2 to
5cf7141
Compare
There was a problem hiding this comment.
Heh...so this got added then reverted and instead of adding it again I thought we could wait till 23.4 released...but that's proving to have been a bad idea. So yes, we should add it here.
I don't think this solution is complete though. Most cloud's won't give you a fallback config, so this shouldn't actually be true on most clouds.
https://github.com/canonical/cloud-init/pull/4612/files
As far as moving it to CI, I think that's probably a good idea, though I think we could probably make this one CI, and the one further down in the file not CI...or maybe just remove that one entirely.
This reverts commit 9c6bbc3.
holmanb
force-pushed
the
holmanb/dhcp6-fix
branch
from
5cf7141 to
8a4923e
Compare
Good point, thanks. I just pushed with that fix.
I just realized that the test I was proposing moving to CI was Bionic-only, and the other one is release agnostic, so nevermind on that proposal. |
This reverts commit 9c6bbc3.
This reverts commit 9c6bbc3.
This reverts commit 9c6bbc3.
This reverts commit 9c6bbc3.
This reverts the temporary changed introduced by PR canonical#4855 that manually dropped the "dhcp6" key from the post_network yaml in the integration test "test_clean_boot_of_upgraded_package"
This reverts the temporary changed introduced by PR canonical#4855 that manually dropped the "dhcp6" key from the post_network yaml in the integration test "test_clean_boot_of_upgraded_package"
This reverts the temporary changed introduced by PR canonical#4855 that manually dropped the "dhcp6" key from the post_network yaml in the integration test "test_clean_boot_of_upgraded_package"
This reverts the temporary changed introduced by PR #4855 that manually dropped the "dhcp6" key from the post_network yaml in the integration test "test_clean_boot_of_upgraded_package"
This reverts the temporary changed introduced by PR #4855 that manually dropped the "dhcp6" key from the post_network yaml in the integration test "test_clean_boot_of_upgraded_package"
Proposed Commit Message
Additional Context
@TheRealFalcon think it is safe to ignore this one? Also this one strikes me as one to maybe run as part of ci, but not sure we should really add more to ci runtime.
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-gce/384/testReport/junit/tests.integration_tests/test_upgrade/test_clean_boot_of_upgraded_package/
Test Steps
Not yet tested
Merge type