Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update webhook test due to removed cc_migrator module #4726

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

test: Update webhook test due to removed cc_migrator module

Removed cc_migrator module means 2 less events, one from start, one
from end.

Additional Context

https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-lxd_container/376/testReport/junit/tests.integration_tests.reporting/test_webhook_reporting/test_webhook_reporting/

I don't love the arbitrary number that changes when the number of modules changes, but I also haven't found a simple way of representing the total number of modules that will run and send events.

Removed cc_migrator module means 2 less events, one from start, one
from end.
@holmanb holmanb self-assigned this Jan 3, 2024
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and tests pass. Thanks!

@blackboxsw
Copy link
Collaborator

unrelated CI linkcheck failure seen here should be resolved by #4734

@blackboxsw blackboxsw merged commit b6a1c63 into canonical:main Jan 4, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants