Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu/jammy 23.4.x #4706

Merged

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Dec 15, 2023

Do not squash

Steps to reproduce

new_upstream_snapshot.py -c 23.4.1 -b 2045582
dch -r -D lunar ''
git commit -m 'releasing cloud-init version 23.4.1-0ubuntu1~22.04.1' debian/changelog
git tag ubuntu/23.4.1-0ubuntu1_22.04.1
  • build-package -- -S -d
  • sbuild --dist=jammy --arch=amd64 --arch-all ../out/cloud-init_23.4.1-0ubuntu1~22.04.1.dsc
  • No lintian errors / warnings.

TheRealFalcon and others added 4 commits December 14, 2023 11:17
fix: Handle systemctl commands when dbus not ready

During `cloud-init status`, we check systemctl to ensure the status
we're reporting is accurate. However, we can get an error from systemctl
if dbus isn't ready yet. This commit will either ignore the error if we
can assume that cloud-init is still running, or retry until we get a
proper response from systemctl.

Fixes canonicalGH-4676
Bump the version in cloudinit/version.py to 23.4.1 and update ChangeLog.
patches:
debian/patches/retain-apt-pre-deb822.patch
debian/patches/status-do-not-remove-duplicated-data.patch
@blackboxsw blackboxsw self-assigned this Jan 2, 2024
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changeset for debian/changelog


* d/p/retain-apt-pre-deb822.patch:
- Disable apt source list generation with DEB822 style
* Upstream snapshot based on 23.4.1. (LP: #2045582).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset, version and pkg build look good. We are missing capture of the refreshed patches in debian/changelog. We also missed this in our first -proposed upload of 23.4-0.

Here's a suggested diff for jammy

--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ cloud-init (23.4.1-0ubuntu0~22.04.1) jammy; urgency=medium
 
   * d/p/retain-apt-pre-deb822.patch:
     - Disable apt source list generation with DEB822 style
+  * refresh patches:
+    - d/p/status-do-not-remove-duplicated-data.patch
+  * d/changelog: amend 23.4-0 refresh patches entry
   * Upstream snapshot based on 23.4.1. (LP: #2045582).
     List of changes from upstream can be found at
     https://raw.githubusercontent.com/canonical/cloud-init/23.4.1/ChangeLog
@@ -15,6 +18,8 @@ cloud-init (23.4-0ubuntu1~22.04.1) jammy; urgency=medium
     - Revert behavior downstream, leave duplicate data
   * d/p/series: bring back retain-old-groups.patch.
     This patch was inadvertently dropped in 5d4a3cf.
+  * refresh patches:
+    - d/p/do-not-block-user-login.patch
   * Upstream snapshot based on 23.4. (LP: #2045582).
     List of changes from upstream can be found at
     https://raw.githubusercontent.com/canonical/cloud-init/23.4/ChangeLog

@blackboxsw blackboxsw force-pushed the ubuntu/jammy-23.4.x branch from 4fdf2e0 to 41cbfec Compare January 2, 2024 22:42
@blackboxsw blackboxsw merged commit 41cbfec into canonical:ubuntu/jammy-23.4.x Jan 3, 2024
26 checks passed
@aciba90 aciba90 deleted the ubuntu/jammy-23.4.x branch January 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants