tests/unittests: add a new unit test for network manager net activator #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani-sinha
force-pushed
the
main
branch
2 times, most recently
from
8da3547 to
9b3b363
Compare
|
@TheRealFalcon sorry I should perhaps have pushed these unit tests along with my previous change. But here it goes now. |
Some changes in behavior in network manager net activator was brought in with the commit d1d5166 ("net/nm: check for presence of ifcfg files when nm connection files are absent") This change adds some unit tests that exercizes network manager activator's bring_up_interface() method that tests failure scenarios as well as cases where an ifcfg file is used to bring the interface up. Signed-off-by: Ani Sinha <anisinha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in behavior in network manager net activator was brought in with the commit
d1d5166 ("net/nm: check for presence of ifcfg files when nm connection files are absent")
This change adds some unit tests that exercizes network manager activator's bring_up_interface() method that tests failure scenarios as well as cases where an ifcfg file is used to bring the interface up.