Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages/brpm): correct syntax error and typo #4661

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Dec 5, 2023

Proposed Commit Message

fix(copr): Multiple fixes to allow COPR builds

Correct syntax error and typo in packages/brpm and remove unneeded
TODO.rst reference from packages/redhat/cloud-init.spec.in.

Additional Context

Successful build with these additional two commits: https://copr.fedorainfracloud.org/coprs/g/cloud-init/el-testing/build/6726068/

Test Steps

bash -x ./tools/run-container --source-package --unittest --artifacts=./srpm/ rockylinux/8

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm adding a followup to scrub these files with ruff and fix formatting issues so we don't find ourselves here in the future,

@blackboxsw blackboxsw merged commit 4d6b96d into canonical:main Dec 5, 2023
26 checks passed
@aciba90 aciba90 deleted the fix-packages-brpm branch December 6, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants