fix(test): Fix expected log for ipv6-only ephemeral network #4641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Testing is good here on EC2 focal with this latest PR. Setting the state_msg in self.ipv6 after success DHCPv6 and either failed DHCPv4 or not self.ipv4 is the proper condition for both dual stack w/ DHCPv4 failures and single stack ipv6 only.
+1
CLOUD_INIT_CLOUD_INIT_SOURCE=/cloud-init_23.3-167-gc48cfd79-1~bddeb_all.deb CLOUD_INIT_PLATFORM=ec2 CLOUD_INIT_OS_IMAGE=focal tox -e integration-tests -- tests/integration_tests/datasources/test_ec2_ipv6.py
....
================== 1 passed, 2 warnings in 624.00s (0:10:24) ===================
blackboxsw
force-pushed
the
holmanb/fix-ipv6-integration-test
branch
from
c48cfd7 to
fc3bd68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-focal-ec2/348/testReport/junit/tests.integration_tests.datasources/test_ec2_ipv6/test_dual_stack/
Test Steps
cloud-init-test.log
Merge type