Fix permissions issue #4628
Merged
Fix permissions issue #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han the new mode (canonical#4250)" This reverts commit a0e4ec1. This commit introduced a broken `compare_permissions()` function. With this implementation, a log file with a mode of 0o407 would remain readable to other users on the system. If the unit tests included in this commit expected the correct output values, the tests would have caught this error.
Previous implementations loosened permissions in non-default scenarios. Fixes canonicalGH-4243
holmanb
force-pushed
the
holmanb/fix-permissions-issue
branch
from
5cb8a84 to
6833c90
Compare
|
Reworded the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
Since cloud-init still redacts sensitive information from
/var/log/cloud-init.log, there is no way to expose a secure system (no CVE). However, #4250 weakens our mitigation of restricting logs by allowing more permissive log permissions. Revert that commit and implement the behavior it was trying to introduce.Checklist
Merge type