Actually validate or tell user we cannot #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmanb
changed the title
blackboxsw
requested changes
Nov 21, 2023
cloudinit/config/schema.py
Outdated
| cloudconfig, schema, strict=True, log_deprecations=False | ||
| ) | ||
| ): | ||
| print("Cannot validate config, jsonschema dependency missing") |
There was a problem hiding this comment.
Let's make this message include Skipping schema validation somehow and we should return False just like our network-config skip above as this function returns False when schema validation is not performed.
Suggested change
| print("Cannot validate config, jsonschema dependency missing") | |
| print("Cannot validate config, jsonschema dependency missing") | |
| return False |
Previously users that didn't have the python jsonschema dependency installed would "succeed" to validate a user configuration. Fix it.
holmanb
force-pushed
the
holmanb/actually-validate-or-tell-user-we-cannot
branch
from
11a7371 to
167c8a4
Compare
|
@blackboxsw Thanks, updated |
blackboxsw
reviewed
Nov 21, 2023
Co-authored-by: Chad Smith <chad.smith@canonical.com>
blackboxsw
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
LGTM thx from adding that whitespace. squash as you see fit. I'm not concerned with unittests/integration tests here as most packaging should be expressing this python3-jsonschema dependency. And we also have debug logs in /var/log/cloud-init.log that' will announce that json schema validation is skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Use commit message