Revert "net: allow dhcp6 configuration from generate_fallback_configu… #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration() (canonical#4474)" This reverts commit 518047a. This commit could cause issues in bringing up the network, especially because in non-netplan NetworkManager environments, may-fail=false .
holmanb
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Agreed, this is the right thing for now.
I agree with the original intent of this PR, but a future approach needs to be able to properly handle the following matrix:
- ipv4-only, ipv6-only, and ipv6+ipv4
- all currently supported renderers
Since the reverted approach appears to break an ipv4-only system with NetworkManager, and also an ipv6-only system with NetworkManager, reverting makes sense. Hopefully a future implementation will come with tests to validate behavior on at least a couple of different renderer-network configurations.
ani-sinha
added a commit
to ani-sinha/cloud-init
that referenced
this pull request
Nov 23, 2023
…uration()" (canonical#4607)" This reverts commit 29ed5f5.
ani-sinha
added a commit
to ani-sinha/cloud-init
that referenced
this pull request
Nov 27, 2023
…guration()" (canonical#4607) This reverts commit 29ed5f5 and therefore, re-applies the commit 518047a . The issue that caused the reversal of 518047a is fixed by the earlier commit: a8da6df ("net/network_manager: do not set "may-fail" to False for both ipv4 and ipv6") Signed-off-by: Ani Sinha <anisinha@redhat.com>
ani-sinha
added a commit
to ani-sinha/cloud-init
that referenced
this pull request
Nov 29, 2023
…guration()" (canonical#4607) This reverts commit 29ed5f5 and therefore, re-applies the commit 518047a . The issue that caused the reversal of 518047a is fixed by the earlier commit: a8da6df ("net/network_manager: do not set "may-fail" to False for both ipv4 and ipv6") Signed-off-by: Ani Sinha <anisinha@redhat.com>
ani-sinha
added a commit
to ani-sinha/cloud-init
that referenced
this pull request
Nov 29, 2023
…guration()" (canonical#4607) This reverts commit 29ed5f5 and therefore, re-applies the commit 518047a . The issue that caused the reversal of 518047a is fixed by the earlier commit: a8da6df ("net/network_manager: do not set "may-fail" to False for both ipv4 and ipv6") Signed-off-by: Ani Sinha <anisinha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Checklist
Merge type