Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subp): Measure subprocess command time #4606

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat(subp): Measure subprocess command time #4606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cloudinit/subp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import logging
import os
import subprocess
import time
from errno import ENOEXEC
from io import TextIOWrapper
from typing import List, Union
Expand Down Expand Up @@ -241,6 +242,7 @@ def subp(
x if isinstance(x, bytes) else x.encode("utf-8") for x in args
]
try:
before = time.time()
sp = subprocess.Popen(
bytes_args,
stdout=stdout,
Expand All @@ -251,6 +253,9 @@ def subp(
cwd=cwd,
)
out, err = sp.communicate(data)
total = time.time() - before
if total > 0.1:
LOG.debug("command %s took %.3ss to run", args, total)
except OSError as e:
raise ProcessExecutionError(
cmd=args,
Expand Down
Loading