Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow aliyun ds to fetch data in init-local #4590

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

ld9379435
Copy link
Contributor

Proposed Commit Message

feat: Allow aliyun ds to fetch data in init-local

In Alibaba Cloud environment, cloud-init supports fetching data before the network services start.

Additional Context

Test Steps

Checklist

@ld9379435 ld9379435 force-pushed the devel/aliyun branch 2 times, most recently from 2b82cfa to e9c548e Compare November 8, 2023 02:40
Copy link

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions bot added the stale-pr Pull request is stale; will be auto-closed soon label Nov 23, 2023
@ld9379435
Copy link
Contributor Author

@TheRealFalcon Please help me to review this commit.thanks

@TheRealFalcon
Copy link
Member

Apologies. Some PR reviews have had to wait due to other project priorities and now holidays. I should be able to get to this one next week.

@TheRealFalcon TheRealFalcon removed the stale-pr Pull request is stale; will be auto-closed soon label Nov 27, 2023
@TheRealFalcon TheRealFalcon self-assigned this Nov 27, 2023
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some inline comments.

Additionally, since I don't have access to an Aliyun instance to test these changes, please attach the resulting tarball from cloud-init collect-logs from an instance launch that includes this code so that I can verify the behavior.

cloudinit/sources/DataSourceAliYun.py Outdated Show resolved Hide resolved
cloudinit/sources/DataSourceAliYun.py Show resolved Hide resolved
tests/unittests/sources/test_aliyun.py Show resolved Hide resolved
@ld9379435
Copy link
Contributor Author

I left some inline comments.

Additionally, since I don't have access to an Aliyun instance to test these changes, please attach the resulting tarball from cloud-init collect-logs from an instance launch that includes this code so that I can verify the behavior.

cloud-init.tar.gz

This is the cloud-init log running on Debian 12 with the commit feature.

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit fe144a5 into canonical:main Dec 1, 2023
26 checks passed
@ld9379435 ld9379435 deleted the devel/aliyun branch March 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants