-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow aliyun ds to fetch data in init-local #4590
Conversation
2b82cfa
to
e9c548e
Compare
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
@TheRealFalcon Please help me to review this commit.thanks |
Apologies. Some PR reviews have had to wait due to other project priorities and now holidays. I should be able to get to this one next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some inline comments.
Additionally, since I don't have access to an Aliyun instance to test these changes, please attach the resulting tarball from cloud-init collect-logs
from an instance launch that includes this code so that I can verify the behavior.
e9c548e
to
8ea8241
Compare
This is the cloud-init log running on Debian 12 with the commit feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed Commit Message
Additional Context
Test Steps
Checklist