-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holmanb/python3.13 #4567
Holmanb/python3.13 #4567
Conversation
fb6fd66
to
e7df772
Compare
Should we close this PR and re-open when the run can work? |
Or maybe the opposite - we open if failing, so that we can easily check in periodically to see if it is failing because of test failures or still failing because of build failures. WDYT? |
Keeping it with a non-vote to CI is good |
Reading about it...is this even an option? It's looks like it's not implemented. actions/runner#2347 |
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
842f6b9
to
961fcbd
Compare
Requires #4669 |
961fcbd
to
a254926
Compare
Will this fail CI if the dev job fails? |
Yep, over 1000 reactions to the top comment and Github still hasn't bothered to implement this. We can let this grow stale until 3.13 is released, if you want, but we had 3.12 as a job before it was released and didn't have any troubles, so alternatively we could just drop 3.13 if it causes troubles. I got a passing run on 3.13, so I'm happy either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively we could just drop 3.13 if it causes troubles
Yeah, I think this makes more sense. Better to get the signal if we need it rather than ignore it due to possible breaking changes from Python, which seem pretty unlikely.
Proposed Commit Message