Clarify boothook docs #4543
Merged
Clarify boothook docs #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way that user-data format doc page is currently written, it seems that boothooks _are_ user-data. Don't specify both.
A reminder that a user has to be aware that the system is booting on a page that describes the order in which the system is booting is unnecessary. Also, calling out a specific module from cloud-config is odd and unnecessary.
holmanb
force-pushed
the
holmanb/boothook-clarifications
branch
from
70af625 to
2c01009
Compare
s-makin
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
I think this makes sense. Thanks for taking the lead on this - I agree it's better not to present these terms without them being explained anywhere, and if the user doesn't need to know about boothooks at all then this definition/term should be avoided except in the dev docs.
aciba90
approved these changes
Oct 24, 2023
blackboxsw
reviewed
Oct 25, 2023
blackboxsw
requested changes
Oct 25, 2023
Co-authored-by: Chad Smith <chad.smith@canonical.com>
blackboxsw
force-pushed
the
holmanb/boothook-clarifications
branch
from
4ffbe47 to
90dbed5
Compare
blackboxsw
approved these changes
Oct 27, 2023
holmanb
added a commit
to holmanb/cloud-init
that referenced
this pull request
Oct 31, 2023
blackboxsw
pushed a commit
that referenced
this pull request
Nov 2, 2023
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Nov 6, 2023
holmanb
added a commit
that referenced
this pull request
Nov 14, 2023
holmanb
added a commit
that referenced
this pull request
Nov 14, 2023
holmanb
added a commit
that referenced
this pull request
Nov 14, 2023
holmanb
added a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
See commit messages for explanations