azure: check for primary interface when performing DHCP #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
azure-primary-check
branch
from
510a391 to
1011437
Compare
cjp256
changed the title
…ption 245, increase test coverage Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
github-actions
bot
added
the
stale-pr
|
@holmanb can you review and merge? Thanks |
Ack, sorry for the delay on this one. EOD now, but will do this tomorrow. |
holmanb
approved these changes
Oct 18, 2023
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
holmanb
pushed a commit
to holmanb/cloud-init
that referenced
this pull request
Oct 31, 2023
* azure: check for primary interface when performing DHCP For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
blackboxsw
pushed a commit
that referenced
this pull request
Nov 2, 2023
* azure: check for primary interface when performing DHCP For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Nov 6, 2023
* azure: check for primary interface when performing DHCP For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
holmanb
pushed a commit
that referenced
this pull request
Nov 14, 2023
* azure: check for primary interface when performing DHCP For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
holmanb
pushed a commit
that referenced
this pull request
Nov 14, 2023
* azure: check for primary interface when performing DHCP For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
holmanb
pushed a commit
that referenced
this pull request
Nov 14, 2023
* azure: check for primary interface when performing DHCP For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
holmanb
pushed a commit
that referenced
this pull request
Nov 14, 2023
* azure: check for primary interface when performing DHCP For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary. Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs. - Return bool from _setup_ephemeral_networking() indicating primary NIC or not. - Remove _check_if_nic_is_primary() used in Savable PPS. - Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen. - Remove some tests that are redundant. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Savable PPS we rely on a connectivity check to IMDS to determine if the NIC is primary. However, in some cases, connectivity may be delayed and we incorrectly assume the NIC is not primary.
Instead of relying on connectivity, check the DHCP-provided route configuration for the presence of Wireserver and/or IMDS IPs.
Return bool from _setup_ephemeral_networking() indicating primary NIC or not.
Remove _check_if_nic_is_primary() used in Savable PPS.
Add a relevant diagnostic to assist debugging failures when a secondary NIC is chosen.
Remove some tests that are redundant.