Drop cc_snap.maybe_install_squashfuse. #1448
Conversation
cc_snap.maybe_install_squashfuse no longer needed in Bionic++. squashfuse install no longer required as snapd feature was backported and released (and Xenial support is no longer available for cloud-init).
| "squashfuse_in_container": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "DEPRECATED: This key is no longer needed and will be removed in a future version of cloud-init." |
There was a problem hiding this comment.
I guess the moment to drop it is now. Do we have to explicitly say something in the changelog or something else? Or should we keep this for backward compatibility?
There was a problem hiding this comment.
I'll let others weigh in here too, but I'm ok dropping it completely since the docs always specified development only.
There was a problem hiding this comment.
I think we are clear enough here to drop. It was an optional thing to use in containers until about 2018 with snapd version 2.32.3.1. It is unnecessary and anybody using this config option doesn't really need to anymore. The workaround if someone really wanted to install squashfuse in a container would be to provide packages: [squashfuse] in #cloud-config if necessary for their appllication (which it shouldn't be).
There was a problem hiding this comment.
Thanks for this cleanup PR. This looks good to me. To your question, I think input from @blackboxsw would be helpful. We are still working out versioning / publishing of the schema.
- no further references of
squashfuse_in_container - no remaining unnecessary references to "squash" or "fuse"
- docs updated in this pr
| "squashfuse_in_container": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "DEPRECATED: This key is no longer needed and will be removed in a future version of cloud-init." |
There was a problem hiding this comment.
I think we are clear enough here to drop. It was an optional thing to use in containers until about 2018 with snapd version 2.32.3.1. It is unnecessary and anybody using this config option doesn't really need to anymore. The workaround if someone really wanted to install squashfuse in a container would be to provide packages: [squashfuse] in #cloud-config if necessary for their appllication (which it shouldn't be).
cc_snap.maybe_install_squashfuse no longer needed in Bionic++.
squashfuse install no longer required as snapd feature was backported
and released (and Xenial support is no longer available for
cloud-init).
Proposed Commit Message
Additional Context
SC-903
Checklist: