Update linters and adapt code for compatibility (SC-986) #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paride
changed the title
| @@ -209,6 +209,7 @@ def handle_hotplug(hotplug_init: Init, devpath, subsystem, udevaction): | |||
| success_fn=hotplug_init._write_to_cache, | |||
| ) # type: UeventHandler | |||
| wait_times = [1, 3, 5, 10, 30] | |||
| last_exception = Exception("Bug while processing hotplug event.") | |||
There was a problem hiding this comment.
We already have a #type: ignore in the else clause for this particular issue. Lets either remove that hint with this change, or remove this change and add another linting hint.
The import happens only if setuptools.errors is not available.
aciba90
pushed a commit
to aciba90/cloud-init
that referenced
this pull request
May 10, 2022
Changes: - pylint 2.13.8: fix E0601(used-before-assignment) - pylint 2.13.8: fix E4702(modified-iterating-dict) - pylint 2.13.8: silence W0402(deprecated-module) on distutils.errors - tox: bump linters versions
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
This should make the
cloud-init-style-tipgreen.Test Steps
Checklist: